Page 1 of 1

DirLight_SetVisible - Bug + Fix

PostPosted: Wed May 27, 2015 4:32 am
by Ortu
Regarding the 2015-03-25 version,

When showing the directional light via DirLight_SetVisible(1), the call to LensFlare_SetVisible(i LensFlareIndex, i Value) incorrectly uses a value of 0 (hide) this must be changed to 1 in order to correctly restore the lensflare when using DirLight_SetVisible(1).

This occurs on line 94 of .\Advanced Lighting\Include\Advanced Lighting\AL_Directional.dba

if AL_DirLightLensFlare.x>-1 then LensFlare_SetVisible(AL_DirLightLensFlare.x,0)

Replace with:

if AL_DirLightLensFlare.x>-1 then LensFlare_SetVisible(AL_DirLightLensFlare.x,1)

Re: DirLight_SetVisible - Bug + Fix

PostPosted: Fri Jul 03, 2015 8:05 pm
by Booma
1) Function DirLight_GetVisible() return float but must return boolean.
2 )In function FogArea_SetCaustics() strange variable tFogArea.
3) In function Water_SetFogColor() variable Water_FogColor has no setup function.
4) In function PostFilter_Delete() stange local variable FilterEnabled

:roll:

Re: DirLight_SetVisible - Bug + Fix

PostPosted: Thu Jul 09, 2015 5:27 pm
by Booma
5) In function AL_GetViewProjectFrustum two variables tLength and tLength# looks like error
6) In function Terrain_Create there is a hardcoded cycle form 0 to 1023, so Terrain_Size must be be equal or more then 1024 (from code: global dim Terrain_Height(Terrain_Size.x,Terrain_Size.y) as float)

Re: DirLight_SetVisible - Bug + Fix

PostPosted: Tue Jul 28, 2015 1:02 pm
by Booma
7) In function PointLight_Render() two heavy commands: dim tSideUpdated(2) as integer and Undim tSideUpdated(), may be better use global array?
8) In function FogArea_Create() variable FogA not from this world
9) In function Terrain_GetHeight() variable Terrain_PositionY always zero
10) In function FogArea_Update() strange variable iFogArea

Re: DirLight_SetVisible - Bug + Fix

PostPosted: Fri Jul 05, 2019 11:36 am
by Arianete
Decent need to accomplish something like this with mine